Ticket #1092 (closed defect: fixed)

Opened 13 years ago

Last modified 13 years ago

Slides should have borders on presentation page

Reported by: hans Owned by: pjotr
Priority: major Milestone:
Component: generic Version:
Keywords: Cc:
Time planned: Time remaining: 0h
Time spent:

Description

Slides should have borders on presentation page. When slide has a white background it is very complicated to understand where one slide ends and the next one begins: http://lemill.net/content/social-web-in-support-of-informal-learning

For border we should use exactly the same CSS class that we use for image borders on multimedia page: http://lemill.net/content/overview-of-lemill

                    <img src="http://lemill.net/content/lemill-content-section-1/image_large"
                         class="media_piece"
                         alt="LeMill content section" />

Change History

comment:1 Changed 13 years ago by pjotr

This one will only be suitable for the "fullscreen_view" ... for the "base_view" with portlets it just brakes the layout.

comment:2 Changed 13 years ago by pjotr

  • Owner changed from anonymous to pjotr
  • Status changed from new to assigned

comment:3 Changed 13 years ago by pjotr

  • Status changed from assigned to closed
  • Resolution set to fixed
  • Time remaining set to 0h

(In [1283]) Fixes #1092

comment:4 Changed 13 years ago by hans

  • Status changed from closed to reopened
  • Resolution fixed deleted

Strange. It breaks the layout also on the student view page. All the slides are moved about 20px to right.

This CSS class should do the following:

img.media_piece {
	margin-bottom: 10px;
	padding: 24px;
	border: 1px solid #cccccc;
	}

It works exactly like that on multimedia pages.

Find a way to make it work like that on presentation pages, both student view and view with portlets.

comment:5 Changed 13 years ago by pjotr

This one will not work for view with portlets, simply because there is no space left there for these paddings. The width at the moment is very close to maximum, so the only solution would be to make the pictures themselves smaller, but that one will not do any good.

comment:6 Changed 13 years ago by pjotr

ok. found the source of teh problem:

.piece-edit-box {

width: 500px; min-height: 375px; text-align: left; /*padding: 18px 24px;*/ - This one is not commented out in normal version. This one seems to add that mesterious gap there margin-top: 4px; background-repeat: no-repeat; background-position: center center;

}

This class is still used in some different places, so what should we do about it?

If pictures need to have these frames for both views, then it will even simplify the code.

comment:7 Changed 13 years ago by pjotr

  • Owner changed from pjotr to hans
  • Status changed from reopened to new

comment:8 Changed 13 years ago by pjotr

  • Owner changed from hans to pjotr
  • Status changed from new to assigned

comment:9 Changed 13 years ago by pjotr

  • Status changed from assigned to closed
  • Resolution set to fixed

(In [1314]) Fixes #1092

Note: See TracTickets for help on using tickets.