Ticket #1228 (closed defect: fixed)

Opened 13 years ago

Last modified 13 years ago

Cover images should always go to action view of the resource

Reported by: tarmo Owned by: anonymous
Priority: waiting Milestone:
Component: generic Version:
Keywords: Cc:
Time planned: Time remaining:
Time spent:


Whenever a cover image is a link, it should take the user to the action view, which has the action portlets. For example on the front page cover images link to students views.

Change History

comment:1 Changed 13 years ago by pjotr

Some time ago ... MaterialTypes? were made to point to "student_view" by default.

Many times it has proven to be problematic and bad, because in many places it has to be checked and material types get "/view" added to their "absolute_url".

Well ... it might be a good time to revert that - "student_view" would get it's small own alias as "/student" for example.

Then we could sweep the system and remove the unnecessary codes that add "/view" for materials - making the codes look better. At the same time the system would be more consistent.

Any comments? I suppose Hans will agree with me on this one.

comment:2 Changed 13 years ago by tarmo

While clean code is a good thing, clean URLs is more important. As the student view is "cleaner" in that it doesn't have action portlets and other details, it should also have the "cleaner" URL, without any extra suffix. So I would not change the way things currently work.

comment:3 Changed 13 years ago by jukka

Since these links ar in page templates and often inside quite hairy code, we cannot automate searching for places where coverimage-links are wrong. So, if any of you find these bad links, comment about it here and it gets fixed. I haven't seen these bad links for a while.

comment:4 Changed 13 years ago by jukka

  • Priority changed from critical to waiting

comment:5 Changed 13 years ago by tarmo

  • Status changed from new to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.