Ticket #1479 (closed defect: wontfix)

Opened 12 years ago

Last modified 12 years ago

New solution to long lines problem

Reported by: pjotr Owned by: laszlo
Priority: minor Milestone:
Component: generic Version:
Keywords: Cc:
Time planned: 2h Time remaining: 0h
Time spent: 36.0h

Description (last modified by pjotr) (diff)

Someone implemented a new solution for the Long symbolic lines problem. But the old code is still used. LeMillTool?.py -> shortenSymbolicLines

I think that CSS solution is better and we should stick with this, but the new solution implemented does not work with IE 7 for me.

We should get rid of that shortenSymbolicLines function, but CSS solution has to get to work with IE first.

http://lemill.org/trac/attachment/ticket/1479/ei_long_lines.jpg?format=raw

http://lemill.org/trac/attachment/ticket/1479/another%20long%20picture.jpg?format=raw

Attachments

ei_long_lines.jpg (258.1 KB) - added by pjotr 12 years ago.
another long picture.jpg (216.7 KB) - added by pjotr 12 years ago.
another long line
Kuva 1.png (67.9 KB) - added by jukka 12 years ago.
javascript solution is broken in Safari 3.0

Change History

Changed 12 years ago by pjotr

comment:1 Changed 12 years ago by pjotr

  • Description modified (diff)

comment:2 Changed 12 years ago by laszlo

  • Owner changed from anonymous to laszlo
  • Status changed from new to assigned
  • Time planned set to 2h

Changed 12 years ago by pjotr

another long line

comment:3 Changed 12 years ago by pjotr

  • Description modified (diff)

comment:4 Changed 12 years ago by laszlo

  • Status changed from assigned to closed
  • Time spent set to 24.0h
  • Resolution set to fixed
  • Time remaining set to 0h

(In [1929]) fixed #1479 spent 24h If you want to use the word wrap in a div, you should set the wrapme class for the tag.

Now it is working in IE and FireFox?. Somebody should extend it to Safari.

comment:5 Changed 12 years ago by tarmo

  • Status changed from closed to reopened
  • Resolution fixed deleted

Solution is not acceptable - no javascript should be placed into the main_template. If this script is needed for a certain widget, then it should be placed into that widget's js section.

comment:6 Changed 12 years ago by laszlo

  • Status changed from reopened to closed
  • Time spent changed from 24.0h to 36.0h
  • Resolution set to fixed

(In [1931]) fixed #1479 spent 12h I've moved JavaScript? to js_helper.js, and extended it for Opera and Safari.

Changed 12 years ago by jukka

javascript solution is broken in Safari 3.0

comment:7 Changed 12 years ago by jukka

  • Status changed from closed to reopened
  • Resolution fixed deleted

Removed javascript in [1955], because solution breaks pages with Safari 3.0. See:

http://lemill.org/trac/attachment/ticket/1479/Kuva%201.png?format=raw

comment:8 Changed 12 years ago by jukka

  • Status changed from reopened to closed
  • Resolution set to wontfix

On second thought, let's just forget the long lines problem for a while.

Note: See TracTickets for help on using tickets.