Ticket #1495 (closed defect: fixed)

Opened 12 years ago

Last modified 12 years ago

Collection scorm download breaks for certain collections

Reported by: tarmo Owned by: gabor
Priority: blocker Milestone:
Component: generic Version:
Keywords: Cc:
Time planned: Time remaining: 0h
Time spent: 30.0h

Description

At least trying to download http://lemill.net/community/Teemu/collections/brief-history-of-new-media throws an error:

    *  Module ZPublisher.Publish, line 115, in publish
    * Module ZPublisher.mapply, line 88, in mapply
    * Module ZPublisher.Publish, line 41, in call_object
    * Module Products.LeMill.Collection, line 903, in download
    * Module Products.LeMill.Collection, line 695, in downloadFiles
    * Module urllib2, line 130, in urlopen
    * Module urllib2, line 350, in open
    * Module urllib2, line 233, in get_type

ValueError: unknown url type:

The absURL that throws this error is an empty string, whereas all the other urls in the set are http protocol urls. So either this entry needs to be removed or corrected.

Change History

comment:1 Changed 12 years ago by gabor

The culprit was the flashvars="" text in the HTML code of "Media Computer - From Math to Augmentation" content which was added as HTML code into a text chapter to display the Google video. I've fixed this type of error, so the download should work for this content, and I hope for the whole collection, too. If you find any other content that breaks the download function, reopen this ticket.

comment:2 Changed 12 years ago by gabor

  • Status changed from new to assigned

comment:3 Changed 12 years ago by gabor

  • Status changed from assigned to closed
  • Time spent set to 30.0h
  • Resolution set to fixed
  • Time remaining set to 0h

(In [1965]) fixed #1495 spent 30h

comment:4 Changed 12 years ago by gabor

According to #1509 users shouldn't have been able to put that <embed> tag into the text chapter in the first place.

comment:5 Changed 12 years ago by tarmo

Embed tags need to be allowed, since they're used to embed google video and sorts.

Note: See TracTickets for help on using tickets.