Ticket #1498 (closed defect: fixed)

Opened 12 years ago

Last modified 12 years ago

Empty description is displayed for media pieces

Reported by: hans Owned by: pjotr
Priority: major Milestone:
Component: generic Version:
Keywords: Cc:
Time planned: Time remaining: 0h
Time spent:

Description (last modified by hans) (diff)

Empty description is displayed for media pieces. If there is no description then we should not display it at all.

http://lemill.net/content/barnacle-goose/

http://lemill.org/trac/attachment/ticket/1498/media_piece_empty_description.jpg?format=raw

Attachments

media_piece_empty_description.jpg (101.0 KB) - added by hans 12 years ago.

Change History

Changed 12 years ago by hans

comment:1 Changed 12 years ago by hans

  • Description modified (diff)

comment:2 Changed 12 years ago by pjotr

Strange. It looks like piece has base_view as a default view written everywhere. But in our skins folder there is also a piece_view.pt and in reality piece is using that to show it's contents.

Mainly Tags will behave in about the same way, as there are no conditions that would restrict field title to appear only if the field is not empty.

Any comments on that?

comment:3 Changed 12 years ago by tarmo

base_view in Archetypes works so that is looks if there's a template called [TYPE]_view.pt (where TYPE is the content type in lowercase) and uses it if it exists. The same with edit.

comment:4 Changed 12 years ago by pjotr

It's quite easy condition stuff, but we should also check all the other types. So that all the fields used the same logic (If field is empty - then we do not show anything).

comment:5 Changed 12 years ago by pjotr

  • Owner changed from anonymous to pjotr
  • Status changed from new to assigned

comment:6 Changed 12 years ago by pjotr

  • Status changed from assigned to closed
  • Resolution set to fixed
  • Time remaining set to 0h

(In [1994]) Fixes #1498, also fixed all the fields for tool and method views

Note: See TracTickets for help on using tickets.