Ticket #1649 (new defect)

Opened 1 year ago

Last modified 8 months ago

Optimizing: CMFPlone skins calls

Reported by: jukka Assigned to: anonymous
Priority: waiting Milestone:
Component: generic Version:
Keywords: optimizing Cc:
Time spent: Time remaining:
Time planned:

Description (Last modified by jukka)

In profiling data there are calls to original plone skins. Some are for reason (discussion items), but some are heavy pages that we should have no reason to load. Find out who calls these and if we can get rid of few of them OR if they do much more than we need them to do, if we can/should make a lightweight version of that page to lemill. (again, discussion items?) Pay attention to total hits, those that are called most often are the most important. 

Template	Total rendering time	Total hits	Time per hit
CMFPlone/skins/plone_content/author.cpt	57.01	36	1.5836
CMFPlone/skins/plone_content/discussionitem_view.pt	135.9	140	0.9707
CMFPlone/skins/plone_content/folder_listing.pt	0.39	1	0.39
CMFPlone/skins/plone_ecmascript/plone_javascript_variables.js.pt	0.09	5	0.018
CMFPlone/skins/plone_forms/search.pt	40.98	23	1.7817
CMFPlone/skins/plone_forms/search_form.pt	7.99	2	3.995
CMFPlone/skins/plone_login/enabling_cookies.pt	1.36	7	0.1943
CMFPlone/skins/plone_login/logged_out.pt	2.97	15	0.198
CMFPlone/skins/plone_portlets/portlet_navtree_macro.pt	114.14	3	38.0467
CMFPlone/skins/plone_templates/contact-info.cpt	147.38	404	0.3648
CMFPlone/skins/plone_templates/default_error_message.pt	94.62	417	0.2269
CMFPlone/skins/plone_templates/index_html.pt	0.25	1	0.25
CMFPlone/skins/plone_templates/search_rss.pt	37.32	20	1.866
CMFPlone/skins/plone_templates/sitemap.pt	161.46	3	53.82

Change History

01/07/08 12:03:10 changed by jukka

  • description changed.

01/07/08 12:31:45 changed by tarmo

/sitemap is something that is mentioned in out page metadata and search bots check it out regularly. It takes over 30 seconds to load... But then again it's not requested very often and it does give nice access to search engines to all our content.

01/10/08 14:23:22 changed by pjotr

Something I was able to dig up:

  • author.cpt -> Plone initial page for showing uthor information. We hold the author infor in a totally different place and change that information differently. There should not be links to that in our code. It can be imported into LeMill codebase and changed to show nothing or do some redirection.
  • discussionitem_view.pt -> only has a redirect directive inside it. Behind that redirection are a lot of different method. They seem quite ok to me. I don't think we could do that in a better way.
  • search.pt -> This must be the page that is showing search results. I don't think we are using that ourselves. Maybe that is mostly called by some bots.
  • search_from.pt -> This is the default Plone Advanced Search form. Our own must have originated fron that. I don't think we are using that, it might be used by some bots or something.
  • portlet_navtree_macro.pt -> as we got rid of portlet_navigation and we are not using that - then the only thing that might be calling that is sitemap.pt (numbers also match).
  • contact-info.cpt -> we use that as a form for contacting us in case of problems. It is prefetching some stuff like User name and Email. If we get rid of that it might start working just a bit quicker. Don't think that would really have any point.
  • search_rss.pt -> that is used on our lemill_search_results.pt and it will not be showing the same info as we get from search. So I don't know if there is a point in even having it there.
  • sitemap.pt -> this one is using some heavy methods and other heavy templates. Rendering that even for my relatively slow instance is a long-lasting process.

01/14/08 12:23:27 changed by jukka

I'd like to see contact-info.cpt and author.cpt fixed.

01/14/08 12:25:15 changed by jukka

Some more data: 

CMFPlone/skins/plone_content/author.cpt	21.6	28	0.7714
CMFPlone/skins/plone_content/discussionitem_view.pt	65.11	137	0.4753
CMFPlone/skins/plone_ecmascript/plone_javascript_variables.js.pt	0.04	2	0.02
CMFPlone/skins/plone_forms/search.pt	24.95	35	0.7129
CMFPlone/skins/plone_forms/search_form.pt	0.24	2	0.12
CMFPlone/skins/plone_login/enabling_cookies.pt	0.56	3	0.1867
CMFPlone/skins/plone_login/logged_out.pt	2.21	15	0.1473
CMFPlone/skins/plone_portlets/portlet_navtree_macro.pt	0.04	4	0.01
CMFPlone/skins/plone_templates/contact-info.cpt	106.11	343	0.3094
CMFPlone/skins/plone_templates/default_error_message.pt	62.97	370	0.1702
CMFPlone/skins/plone_templates/index_html.pt	0.12	1	0.12
CMFPlone/skins/plone_templates/search_rss.pt	5.5	14	0.3929
CMFPlone/skins/plone_templates/sitemap.pt	61.28	4	15.32

05/13/08 18:48:39 changed by jukka

  • priority changed from major to waiting.

I think Pjotr made progress with this, but let's keep this visible for future reference.